dhruvasagar/vim-table-mode

table_mode_align_char doesn't work with multi-line headers

Open

#203 opened on Jul 13, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Vim Script (98 forks)batch import
hacktoberfesthelp wanted

Repository metrics

Stars
 (2,236 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Suppose I make a table with a right alignment marker in the second column:

| first thing | second thing |
|-------------+-------------:|
| 1           |      2       |

If I run :TableModeRealign, the second column is right-aligned as expected:

| first thing | second thing |
|-------------+-------------:|
| 1           |            2 |

But if I use multiple lines in the header:

| first | second |
| thing | thing  |
|-------+-------:|
| 1     |   2    |

then run :TableModeRealign, I instead get left alignment:

| first | second |
| thing | thing  |
|-------+-------:|
| 1     | 2      |

This seems to be caused by the interaction of tablemode#align#Align and tablemode#align#alignments, together assuming a border line will appear after the first text line.

Contributor guide

Research direction
Examine the `tablemode#align#Align` and `tablemode#align#alignments` functions to understand why they assume the first line of the header is the border line, causing misalignment with multi line headers.
Tech stack
None
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Vim basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70