Decoding HTTP error messages

Open
#1 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
30/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start at views/Admin.bones around line 59 and inspect the Admin.bones error function and its AdminGrowl call. Verify how standardized Bones API error responses expose message and status, then confirm that the growl displays the decoded message for an HTTP response and preserves the existing fallback for other errors.

Written by the indexing model from the issue text.

Description

Since bones API endpoints error returns are standardized to return a hash containing a message and a status property, should we decode these hashes in Admin.bones' error function?.

Something like:

error: function(model, resp) {
    var message = resp;
    if (resp instanceof Object && resp.responseText) {
        var obj = JSON.parse(resp.responseText);
        if (obj.message) {
            message = obj.message
        }
    }
    new views['AdminGrowl']({
        message: message,
        classes: 'error',
        autoclose: 0
    });
}
Dominant language
JavaScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.