Email feature requests: reply-to, subject, from

Open
#76 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start in apps/mailman/mailer.py and inspect the MailMaker and MailSurvey implementations, then trace how the MailSurvey subject is supplied from the UI. Confirm the default sender, optional reply-to behavior, and survey subject handling against the issue; done means all three email feature requests work without changing unspecified behavior.

Written by the indexing model from the issue text.

Description

Probably makes sense to address these all in a single FR / branch.

Code: https://github.com/developmentseed/api.work.vote/blob/master/apps/mailman/mailer.py

  • Set MailSurvey to use settings.DEFAULT_SURVEY_FROM_EMAIL instead of DEFAULT_FROM_EMAIL.
  • Allow specifying separate reply-to for both MailMaker and MailSurvey. For now can just have them default to None / not set. Need to check with FEC what they want here.
  • Check that MailSurvey subject lines are set correctly from UI; it seems they always get set to "Workelections.com Survey" instead.
Dominant language
Python
Stars
6
Forks
7
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from developmentseed/api.work.vote

All issues in developmentseed/api.work.vote

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.