developit/workerize-loader

Fails when a depedency (module) requires a webpack "external" module

Open

#22 opened on Feb 14, 2018

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (111 forks)batch import
help wantedquestion

Repository metrics

Stars
 (2,296 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Awesome library! I've just found an edge case when workerizing a module that depends on a webpack external.

In my webpack config i have:

module.exports = {
  // ...
  externals: {
    'config': JSON.stringify(config),
  },
  // ...
}

and in my worker module I have:

import * as config from 'config';

I'm using typescript in case that matters.

Here's the compilation error from webpack:

Module not found: Error: Can't resolve 'config' in '/directory/src'
 @ ./src/MyWorker.ts 1:0-33

Contributor guide

Research direction
Investigate the workerize loader source code, particularly the part that resolves dependencies for the worker. The issue is that webpack externals are not passed to the worker bundle. A possible fix is to include the externals configuration in the worker's webpack config or to alias them. Look at the loader's implementation in src/loader.js (or similar) and the test directory for existing tests.
Tech stack
javascripttypescript
Domain
build systemtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
webpackworkerize loaderTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40