Security vulnerability via transitive dependency on `serialize-javascript` via `rollup-plugin-terser`

Open
#1,100 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript, rollup
Domain
build-system, security

Research direction

Inspect microbundle's dependency declaration for rollup-plugin-terser and the resulting serialize-javascript dependency chain. Try the proposed @rollup/plugin-terser replacement, run the existing build or test commands, and confirm that the vulnerability is gone without introducing regressions.

Written by the indexing model from the issue text.

Description

I've started to see vulnerability reports on a number of projects that all look like this: https://github.com/bullet-train-co/bullet_train-core/security/dependabot/557

The issue arises because microbundle depends on the deprecated rollup-plugin-terser package which has its dependency on serialize-javascript declared with ^4.0.0.

Updating microbundle to @rollup/plugin-terser should fix the dependency chain, but I don't know if it would introduce other issues.

Dominant language
JavaScript
Stars
8.1k
Forks
358
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from developit/microbundle

All issues in developit/microbundle

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.