developit/decko

Is memoize supposed to work on getters?

Open

#15 opened on Feb 8, 2018

View on GitHub
 (2 comments) (8 reactions) (0 assignees)JavaScript (34 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,037 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

(tested in Typescript)

import { memoize } from 'decko';

class Stores(){
}

class Container {

    @memoize
    public get stores () {
        return new Stores();
    }
}

Throws an error: ​​Invalid property descriptor. Cannot both specify accessors and a value or writable attribute, #<Object>​​

For reference: https://github.com/darrylhodgins/typescript-memoize does work.

Contributor guide

Research direction
Investigate the error when applying @memoize to a getter. The error indicates a conflict between accessor and value descriptor. Modify the memoize decorator to handle getters by storing the computed value in a WeakMap or similar, and ensure the descriptor is correctly set.
Tech stack
javascripttypescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTypeScriptDecorators
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
72