Variable substitution does not allow default values containing a colon

Open
#883 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
cli

Research direction

Start by tracing the localEnv and containerEnv substitution handling and reproduce the provided WEBSITE_URL example. Check how colon-separated default values are parsed. Done means an unset variable preserves the complete default value, including https://example.com, with regression coverage for the reported case.

Written by the indexing model from the issue text.

Description

bug

The current implementation does not support default values in localEnv or containerEnv substitution that include a colon.

Example:

 "WEBSITE_URL": "${localEnv:WEBSITE_URL:https://example.com"

Current behavior: If $WEBSITE_URL is not present, the variable is just set to https

Expected behavior: If $WEBSITE_URL is not present, the variable should be set to https://example.com

Dominant language
TypeScript
Stars
3k
Forks
461
Avg merge
18m
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from devcontainers/cli

All issues in devcontainers/cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.