CI never runs the workflow-run cleanup test
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start in .github/workflows/ci.yaml by comparing the existing cask-pr-handoff and eks-smoke-scripts changes filters and jobs, then inspect require-checks-in-pr. Add coverage for the cleanup script, its test, and .github/fixtures/workflow-run-cleanup/**, including shellcheck and the test run, and wire the job into the required checks. Confirm with a deliberate regression that the new job fails.
Written by the indexing model from the issue text.
Description
🤖 Generated by the Agentic Engineer
Evidence
.github/scripts/delete-old-workflow-runs.test.sh exists and passes, but no CI job ever runs it.
.github/workflows/ci.yaml gates shell-script tests behind an explicit allow-list — one changes
path filter plus one job per script group. Two such groups exist today (cask-pr-handoff,
eks-smoke-scripts). The workflow-run cleanup script is in neither, and the only other reference to
it anywhere under .github/ is the delete-old-workflow-runs job name in maintenance.yaml, which
invokes the script in production but never its test.
Verified at head 4d8dbcb0 of #6685: grep -rn "delete-old-workflow-runs" .github/ returns exactly
one hit, in maintenance.yaml.
Impact
The nightly Maintenance workflow is the only thing that exercises this script, and it does so
directly against main. A regression is therefore discovered by the default branch going red — which
is precisely what happened in #6683 — rather than by a pull request failing.
That makes the test added in #6685 a one-time proof rather than a standing guard: nothing stops the
same class of failure returning.
Expected
A change to the cleanup script or its test runs that test in CI, and a failure blocks the pull
request instead of reaching main.
Acceptance criteria
- A
changespath filter covering.github/scripts/delete-old-workflow-runs.sh,
.github/scripts/delete-old-workflow-runs.test.sh,.github/fixtures/workflow-run-cleanup/**,
and.github/workflows/ci.yaml. - A job that
shellchecks the script, its test, and its fixturegh, then runs the test — mirroring
the existingeks-smoke-scriptsjob. - The job is wired into
require-checks-in-pr(bothneedsandjob-results), ascask-pr-handoff
already is, so it actually gates. A skipped path-filtered job is treated as a pass there today, so
this does not block unrelated PRs. - Proven by a deliberate regression: ablate the fix, confirm the new job fails.
Size
Small — configuration only, mirroring a pattern already present twice in the same file.
- Dominant language
- Go
- Stars
- 165
- Forks
- 13
- Avg merge
- 4h 17m
- Merged PRs (30d)
- 362
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from devantler-tech/ksail
-
dependencies go
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
devantler-tech/ksail#7135 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
devantler-tech/ksail#6977 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
devantler-tech/ksail#6975 ·
-
fix(webui): unmanaged clusters with URL-unsafe context names (EKS ARNs) 404 from every web request Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
devantler-tech/ksail#6908 ·
-
Opt ci-go's workflow_call arm out of signed auto-fixes so it does not race the org-required signer Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
devantler-tech/ksail#6863 ·
All issues in devantler-tech/ksail
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100