derhuerst/synchronous-autocomplete-rs

help me make the code more idiomatic

Open

#1 opened on May 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (0 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (0 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm a Rust beginner, so probably there are a few antipatterns in the codebase. I'm grateful for hints about how to solve some problems more elegantly. Specifically:

float ordering: https://github.com/derhuerst/synchronous-autocomplete-rs/blob/12fc8890a004f073b56f731352d527f032e2050a/src/lib.rs#L143-L147

stop inserting & truncating: https://github.com/derhuerst/synchronous-autocomplete-rs/blob/12fc8890a004f073b56f731352d527f032e2050a/src/lib.rs#L150-L151

DRY the deep equal logic: https://github.com/derhuerst/synchronous-autocomplete-rs/blob/12fc8890a004f073b56f731352d527f032e2050a/src/lib.rs#L209

find a way to run the benchmarks without running tests: https://github.com/derhuerst/synchronous-autocomplete-rs/blob/12fc8890a004f073b56f731352d527f032e2050a/benches/main.rs#L30-L34

Contributor guide

Research direction
Review the linked code sections and suggest idiomatic Rust patterns for float ordering, inserting/truncating, DRY deep equal, and benchmark separation.
Tech stack
rust
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70