derhuerst/redis-stream

reader: fix race condition

Open

#6 opened on Jun 2, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (7 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

https://github.com/derhuerst/redis-stream/blob/bac7d4618750ea074b6411ca540341ccd1da9152/reader.js#L19-L55

read(size) will call xread(cursor), but set cursor in the callback. After multiple read() calls, their callbacks will race to overwrite cursor.

Contributor guide

Research direction
Examine the reader.js file around lines 19-55 to understand how cursor is set in callbacks, and propose a fix using a queue or mutex to ensure sequential handling.
Tech stack
javascript
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70