derhuerst/email-providers

index.js: transform array into Set for quick lookup

Open

#11 opened on Sep 10, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (53 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've made this exact request in another package, but this is a request to ship a js Map or js Object along with/instead of the array version.

The lookup on the Map/Object is O(1) while array is O(n). When checking upon signups and signins, this makes a difference when there are many requests per second.

Thanks.

Contributor guide

Research direction
Review the current use of the array in index.js and replace it with a Set or Map to achieve O(1) lookup time. Ensure backward compatibility.
Tech stack
javascript
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80