dequelabs/axe-core

dom.isFocusable should consider `audio` and `video` controls

Open

#1,237 opened on Nov 13, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (5,457 stars) (783 forks)batch import
featgood first issue

Description

dom.isFocusable function to be updated to consider audio and video controls.

Contributor guide

Tech stack
javascript
Domain
accessibilitytesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HTML accessibilityaxe core codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, locate the `dom.isFocusable` function in the axe core source code, likely in `lib/dom/is focusable.js`. Read the current implementation to understand how focusability is determined. Then, consult the HTML specification to determine when `audio` and `video` elements (with controls attribute) are focusable. Modify the function to include these cases. Check existing tests in `test/dom/is focusable.js` and add test cases for `audio` and `video` elements with and without controls.