Deployer appends known hosts rather than replacing them
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- github-actions
- Domain
- devops, documentation
Research direction
Locate the documentation for the known hosts option and read how its current behavior is described. Update that documentation to state whether entries are appended or replaced, then verify the wording clearly explains the resulting SSH fingerprint behavior.
Written by the indexing model from the issue text.
Description
TLDR: the known hosts option implies it replaces the file, but it actually appends to it, which is not mentioned!
We've added the new github RSA fingerprints to a known hosts secret, along with several others, then told deployer to use it.
Unfortunately, deployer appends these to a known hosts file that has out of date fingerprints rather than replacing/overwriting, so we still get the SSH fingerprint problem despite adding the new entries.
As a workaround we're going to test removing all github fingerprints before running the deployer, but the documentation should be updated to make it clear that the action appends/extends, and does not replace/overwrite as currently implied
Upvote & Fund
- We're using Polar.sh so you can upvote and help fund this issue.
- We receive the funding once the issue is completed & confirmed by you.
- Thank you in advance for helping prioritize & fund our backlog.
- Dominant language
- TypeScript
- Stars
- 269
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from deployphp/action
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
Puzzling ssh fail Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
All issues in deployphp/action
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dennys-bd/agent-hive#184 ·
-
Add: hunch Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
AbdelStark/awesome-typesafe#104 ·
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vicharanashala/fln#563 ·