denosaurs/denon

Trigger failsafe if many reloads are triggered

Open

#54 opened on May 29, 2020

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)TypeScript (43 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (1,109 stars)
PR merge metrics
 (PR metrics pending)

Description

Not sure if this is the correct way to do it, but I wanted to save a cache script I could easily run.

"cache": {
      "desc": "Cache versions and update lock file",
      "cmd": "deno cache server.ts --lock-write",
      "lock": "./lock.json"
}

The result however when running denon cache is an endless loop instead of just executing it once, looks like this:

Skärmavbild 2020-05-29 kl 19 10 40

Now is this a bug or aren't you suppose to add and execute scripts in this way?

Contributor guide

Research direction
Investigate the script execution mechanism in denon to understand why a custom script triggers an endless loop. Look at how commands are dispatched and if there is a failsafe for frequent reloads.
Tech stack
typescript
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Deno basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70