denisidoro/navi

Bash widget not working with readline vi editing mode

Open

#328 opened on Apr 2, 2020

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Rust (15,874 stars) (530 forks)batch import
bughelp wanted

Description

Describe the bug When using bash with readline set to vi editing mode the widget does not work.

To Reproduce

Steps to reproduce the behavior:

set -o vi
source <(navi widget bash)

Then press CTRL-G and navi will not run but instead the terminal will print:

`__call_navi`

Expected behavior If you then go back to the default readline editing mode which is emacs, you get the expected behavior and navi runs.

set -o emacs
source <(navi widget bash)

Versions:

  • navi: 2.5.0
  • OS: Ubuntu 18.04
  • Shell Version: GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)

Contributor guide

Tech stack
shell
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of bashunderstanding of readline modes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the bash widget script in the repository (likely in scripts/widget.sh) to understand how it binds Ctrl G. Determine why the binding does not work when readline is in vi mode. Check if there is a difference in how vi mode handles key bindings and ensure the widget works in both emacs and vi modes. Consider adding conditional logic to handle vi mode.