deniscerri/ytdlnis

Implement download dialog

Open

#441 opened on Mar 29, 2024

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Kotlin (8,590 stars) (369 forks)batch import
enhancementhelp wanted

Description

Is your feature request available in yt-dlp? Please describe. I'm always frustrated whenI click the download button on YouTube ReVanced and the app goes to PiP mode[...]

Describe the solution you'd like Cause the download window to be invoked without enabling PiP in YouTube ReVanced.

Describe alternatives you've considered With NewPipe I can download without activating YouTube ReVanced's PiP mode.

Additional context Thanks for your great work. 🙏🏽 Screenshot_20240328-204941

Contributor guide

Tech stack
kotlinandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
KotlinAndroid StudioAndroid UI development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current download flow to understand when PiP mode is triggered. Look for the download button onClick handler in MainActivity or a fragment. Check the issue comments for any suggested patches. Plan to create a new dialog fragment for download progress that does not trigger PiP.