delta-io/delta

[Kernel][Testing] Add more thorough testing for DataType.toJson

Closed

#2,313 opened on Nov 20, 2023

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Scala (2,159 forks)batch import
enhancementgood first issuekernelstale

Repository metrics

Stars
 (8,950 stars)
PR merge metrics
 (PR metrics pending)

Description

Feature request

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Overview

All of our DataType classes provide toJson which serializes the type following the delta protocol schema serialization rules https://github.com/delta-io/delta/blob/master/PROTOCOL.md#schema-serialization-format. We use this method to serialize the physical and logical schemas in ScanStateRow.

toJson is only tested by the 2 round-trip tests in DefaultJsonHandlerSuite. We should add more thorough tests for toJson.

Contributor guide

Research direction
Examine the existing DefaultJsonHandlerSuite to understand the current round trip tests for toJson, then create comprehensive unit tests for each DataType subclass covering various schema serialization scenarios.
Tech stack
scala
Domain
databasebackend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ScalaTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60