dekatotoro/SlideMenuControllerSwift

handleRightPanGesture/ handleLeftPanGesture calls not stable

Open

#170 opened on May 23, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (748 forks)github user discovery
help wanted

Repository metrics

Stars
 (3,379 stars)
PR merge metrics
 (PR metrics pending)

Description

Hello, I modified the sample app and changed the width of right/ left view controller.

` let slideMenuController = ExSlideMenuController(mainViewController:nvc, leftMenuViewController: leftViewController, rightMenuViewController: rightViewController) slideMenuController.automaticallyAdjustsScrollViewInsets = true slideMenuController.delegate = mainViewController self.window?.backgroundColor = UIColor(red: 236.0, green: 238.0, blue: 241.0, alpha: 1.0) self.window?.rootViewController = slideMenuController

    slideMenuController.changeRightViewWidth(340.0)
    slideMenuController.changeLeftViewWidth(340.0)

`

  1. Swiping right-left 30 px from the edge (Works)
  2. Swiping left-right 30 px from the edge (Doesn't work)
  3. Swipe right-left 50 px from the edge (handleRightPanGesture get called)
  4. Swipe left-right 50-100 px range from the edge (Sometimes handleRightPanGesture gets called)

If I change the width of right/ left VC in "SlideMenuOptions" struct then it works fine.

Please let me know if anyone else faced this and has a solution?

Thanks.

Contributor guide

Research direction
Investigate the gesture recognizer setup in SlideMenuController when custom widths are set via changeRightViewWidth/changeLeftViewWidth. Compare with default options initialization to identify missing configuration for edge gestures. Check if pan gesture thresholds are correctly adjusted for the new width.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
SwiftiOS developmentUIGestureRecognizer
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60