Compression training: when quantizer_kernel is enabled, the check target of "rounding" param should be "nearest" instead of "nearest_neighbor"

Open Beginner friendly
#4,013 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
machine-learning

Research direction

Start at deepspeed/runtime/quantize.py around line 155 and compare the check for q_rounding with the weight-quantization documentation. Confirm that the validation matches the documented "nearest" value rather than "nearest_neighbor"; done means the configuration check accepts the documented setting.

Written by the indexing model from the issue text.

Description

https://github.com/microsoft/DeepSpeed/blob/11f8e4a5c81ed0553ec1b371fd9d5eee229bdcf0/deepspeed/runtime/quantize.py#L155C73-L155C73
According to https://www.deepspeed.ai/docs/config-json/#weight-quantization, we should check whether self.q_rounding is "nearest", not "nearest_neighbor".

Dominant language
Python
Stars
43.1k
Forks
5k
Avg merge
4d 19h
Merged PRs (30d)
116

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from deepspeedai/DeepSpeed

All issues in deepspeedai/DeepSpeed

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.