[Code scan] Forward c in make_graphene_rect's reshape path
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
Read tbplas/materials/graphene.py around lines 68-71 and trace the reshape branch of make_graphene_rect. Verify that a non-default c value is passed through to the diamond-cell construction and that the resulting rectangular cell uses that value.
Written by the indexing model from the issue text.
Description
This issue comes from a Codex global scan of deepmodeling/tbplas at commit 4d3652b3dba8eb930e4869a6d41074f62d703692.
Severity: Medium
make_graphene_rect(from_scratch=False, c=...) rebuilds the rectangular cell by reshaping a diamond graphene cell, but it calls make_graphene_diamond(t=t) without forwarding c. Callers who request a non-default c-axis get a reshaped cell based on c=1.0 instead.
Code reference:
https://github.com/deepmodeling/tbplas/blob/4d3652b3dba8eb930e4869a6d41074f62d703692/tbplas/materials/graphene.py#L68-L71
Suggested fix: call make_graphene_diamond(c=c, t=t) in the reshape branch.
- Dominant language
- No language data
- Stars
- 19
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from deepmodeling/tbplas
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
deepmodeling/tbplas#28 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
deepmodeling/tbplas#27 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
deepmodeling/tbplas#26 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
deepmodeling/tbplas#25 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
deepmodeling/tbplas#24 ·
All issues in deepmodeling/tbplas
Similar issues
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100