[Code scan] Missing NVE systems crash stability scoring instead of receiving the failure penalty
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start in lambench/metrics/vishelper/metrics_calculations.py at the linked _calculate_instability_error() code and inspect how DataFrame.from_dict creates missing cells. Add a regression test with one model missing a system present for another, then verify that non-dict, null, and NaN cells receive the failure penalty of 5 instead of crashing.
Written by the indexing model from the issue text.
Description
This issue was found by a Codex global repository scan of tracked non-test files at commit 8c93925cb10b401b2b83c738bd9263fd74474468.
Relevant code
Impact
DataFrame.from_dict(..., orient="index") fills missing per-system NVE entries with NaN. _calculate_instability_error() handles None, but then calls cell.get(...) on the cell value. For NaN, that raises AttributeError instead of returning the documented failure penalty.
A model with one missing NVE system can crash stability scoring rather than receiving the intended penalty.
Suggested fix
Treat non-dict, null, and NaN cells as failed simulations and return 5. Add a regression test where one model is missing a system present for another model.
- Dominant language
- Python
- Stars
- 20
- Forks
- 11
- Avg merge
- 30m
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from deepmodeling/LAMBench
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
deepmodeling/LAMBench#443 ·
-
Difficulty 2/5 Half a day Newbie friendliness 74/100
deepmodeling/LAMBench#439 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
deepmodeling/LAMBench#438 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
deepmodeling/LAMBench#436 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
deepmodeling/LAMBench#435 ·
All issues in deepmodeling/LAMBench
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100