mirror pull: --proxy-registry validates packages too late (fails mid-pull)

Open Beginner friendly
#428 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
cli

Research direction

Start in internal/mirror/cmd/pull/validation.go at validateProxyRegistryFlag, then compare the proxy-mode package behavior in internal/mirror/packages/packages.go. Confirm the existing platform and module validation flow and ensure package pulls require --include-package or --no-packages. Done means the example command fails during initial validation with an actionable error instead of during the packages phase.

Written by the indexing model from the issue text.

Description

Summary

--proxy-registry does not validate the packages requirement up front. When packages are being pulled (not skipped) and no --include-package is given, the pull passes pre-run validation and then fails late, during the packages phase.

Details

  • internal/mirror/cmd/pull/validation.go — validateProxyRegistryFlag enforces the --include-platform (platform) and --include-module@<constraint> (modules) requirements, but never considers packages.
  • internal/mirror/packages/packages.go — in proxy mode, discoverPackageNames requires a whitelist and errors with --proxy-registry requires a whitelist of packages (--include-package).

So a command like:

d8 mirror pull /tmp/bundle --proxy-registry \
  --include-platform ">=1.64" \
  --include-module foo@^1.0.0

(packages left enabled, no --include-package) passes validation, does the platform/module work, and only then aborts in the packages phase.

Impact

Late failure after significant work, instead of an immediate, actionable validation error at startup.

Expected

Validate the packages requirement in validateProxyRegistryFlag — require --include-package (or --no-packages) when proxy mode pulls packages — symmetric with the existing modules/platform checks.

Severity: medium (UX). As of main (62132d6a).

Dominant language
Go
Stars
20
Forks
7
Avg merge
3d 16h
Merged PRs (30d)
33

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from deckhouse/deckhouse-cli

All issues in deckhouse/deckhouse-cli

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.