decentralized-identity/ion

CLI creates payload is outdated key type

Open

#229 opened on Sep 7, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (168 forks)batch import
good first issuehigh prioirtyimprovement

Repository metrics

Stars
 (1,219 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As of

  "name": "ion",
  "version": "1.0.3",
{
        "action": "replace",
        "document": {
          "publicKeys": [
            {
              "id": "signing-key",
              "type": "EcdsaSecp256k1VerificationKey2019",
              "publicKeyJwk": {
                "kty": "EC",
                "crv": "secp256k1",
                "x": "qp0Ezzc4YhA196COYKa-RHrCom-0LgFtAf8FqvcntN0",
                "y": "zWcbbbg9w1m-DNOszvM68TD0_vFBtWyc18S06c8cULU"
              }
            }
          ]
        }
      }

Should be

{
        "action": "replace",
        "document": {
          "publicKeys": [
            {
              "id": "signing-key",
              "type": "JsonWebKey2020",
              "publicKeyJwk": {
                "kty": "EC",
                "crv": "secp256k1",
                "x": "qp0Ezzc4YhA196COYKa-RHrCom-0LgFtAf8FqvcntN0",
                "y": "zWcbbbg9w1m-DNOszvM68TD0_vFBtWyc18S06c8cULU"
              }
            }
          ]
        }
      }

This is low priority, but will harm interoperability with JsonWebSignature2020, better not to encourage that key type to be used.

Contributor guide