zephyrproject-rtos/zephyr

Drop Futile BUILD_ASSERTs in tmc5xxx series

Open

#109.856 geöffnet am 26. Mai 2026

Auf GitHub ansehen
 (2 Kommentare) (1 Reaktion) (1 zugewiesene Person)C (15.249 Stars) (9.144 Forks)batch import
Good first issuearea: Stepper

Beschreibung

Summary

stallguard_threshold_velocity is actually part of adi,tmc5xxx-stepper-ctrl bindings. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/dts/bindings/stepper/adi/adi%2Ctmc50xx-stepper-ctrl.yaml#L10 https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_ctrl.c#L493

However, couple of other drivers in the tmc5xxx series do BUILD_ASSERT on this property. The ASSERT never actually happens since it's guarded by a COND_CODE_1, which would never be tree, hence it's actually futile.

https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

Describe the solution you'd like

Drop the ASSERTs listed below.

  1. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

  2. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_driver.c#L205-L207

  3. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc50xx/tmc50xx_stepper_driver.c#L170-L172

Alternatives

No response

Additional Context

No response

Contributor Guide

Tech Stack
c
Domain
backend
Issue Type
refactor
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
under 1 hour
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
blocked
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
C programming
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
40
Research-Richtung
The issue involves removing three futile BUILD ASSERT macros from files: drivers/stepper/adi tmc/tmc51xx/tmc51xx.c (lines 528-530), drivers/stepper/adi tmc/tmc51xx/tmc51xx stepper driver.c (lines 205-207), and drivers/stepper/adi tmc/tmc50xx/tmc50xx stepper driver.c (lines 170-172). The asserts are guarded by COND CODE 1 on a property that never exists, so they are dead code. The fix is to delete those lines. The issue is assigned but has no open PR, so check assignee status before starting.