yugabyte/yugabyte-db

[DocDB] IntentAwareIterator::Next() does not advance intent iterator

Open

#22.605 geöffnet am 29. Mai 2024

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (1 zugewiesene Person)C (1.003 Forks)batch import
area/docdbgood first issuekind/bugpriority/low

Repository-Metriken

Stars
 (8.229 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 17T 21h) (92 gemergte PRs in 30 T)

Beschreibung

Jira Link: DB-11515

Description

Current implementation of the method:

void IntentAwareIterator::Next() {
  VLOG_WITH_FUNC(4);

  if (!status_.ok()) {
    return;
  }

  if (IsEntryRegular()) {
    SkipFutureRecords<Direction::kForward>(iter_.Next());
    FillEntry();
  }
}

There is no logic for the intent_iter_, which seems wrong as it should be moved next in some cases.

Currently, the method is used only from GetHelperBase::Prepare() for the row getter initialization. And it does not lead to any inconsistency, but gives an extra decoding (i.e. for a packed record or delete record) and maybe one extra Seek/Next call.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor Guide