yugabyte/yugabyte-db

[DocDB] All rocksdb_block_cache prometheus statistics are wrongly annotated as gauges, should be counters

Open

#18.040 geöffnet am 1. Juli 2023

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (1 zugewiesene Person)C (1.003 Forks)batch import
area/docdbdatapath-onboardinggood first issuehelp wantedkind/bugpriority/medium

Repository-Metriken

Stars
 (8.229 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 17T 21h) (92 gemergte PRs in 30 T)

Beschreibung

Jira Link: DB-7092

Description

When looking at the DocDB rocksdb_block_cache statistic metadata for prometheus, the statistics are wrongly annotated as gauges, these should be counters (it's even indicated in the HELP text: 'Rocksdb Ticker':

# HELP rocksdb_block_cache_data_hit Per-tablet Regular Rocksdb Ticker for rocksdb_block_cache_data_hit
# TYPE rocksdb_block_cache_data_hit gauge
rocksdb_block_cache_data_hit{table_id="00004000000030008000000000004004.colocation.parent.uuid",table_name="00004000000030008000000000004004.colocation.parent.tablename",namespace_name="taqo",table_type="PGSQL_TABLE_TYPE",metric_type="tablet",exported_instance="yb-15-tverona-taqo-test1-n1"} 8 1688214784225
# HELP rocksdb_block_cache_data_hit Per-tablet Regular Rocksdb Ticker for rocksdb_block_cache_data_hit
# TYPE rocksdb_block_cache_data_hit gauge
rocksdb_block_cache_data_hit{table_id="000033f6000030008000000000004000",table_name="write_read_test",namespace_name="system_platform",table_type="PGSQL_TABLE_TYPE",metric_type="tablet",exported_instance="yb-15-tverona-taqo-test1-n1"} 0 1688214784225
# HELP rocksdb_block_cache_data_hit Per-tablet Regular Rocksdb Ticker for rocksdb_block_cache_data_hit
# TYPE rocksdb_block_cache_data_hit gauge
rocksdb_block_cache_data_hit{table_id="ec73ca3449214bad94979a3796e3b7aa",table_name="transactions",namespace_name="system",table_type="TRANSACTION_STATUS_TABLE_TYPE",metric_type="tablet",exported_instance="yb-15-tverona-taqo-test1-n1"} 0 1688214784225

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Contributor Guide