vinitshahdeo/PortScanner

The low & high range of ports in scanner.py is hardcoded

Offen

#1 geöffnet am 04.06.2020

 (6 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (122 Forks)auto 404
beginner friendlyfirst-timers-onlygood first issuehelp wantedup for grabs

Repository-Metriken

Stars
 (150 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Reading config.json and using range.low and range.high in scanner.py


The range for ports shouldn't be hardcoded. It should be ideally fetched from config.json as it's being used in server/index.js.

for port in range(1,8888):  
        sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
        result = sock.connect_ex((remoteServerIP, port))
        if result == 0:
            print "Port {}: 	 Open".format(port)
        sock.close()

Contributor Guide