Only warn about small files when they are not empty
#1.065 geöffnet am 21. Okt. 2019
Repository-Metriken
- Stars
- (21.837 Stars)
- PR-Merge-Metriken
- (Durchschn. Merge 8T 16h) (110 gemergte PRs in 30 T)
Beschreibung
This is a follow up to https://github.com/timberio/vector/pull/863#issuecomment-544314174.
To recap, when the file source is configured to use the checksum fingerprinting strategy a warning log message is emitted letting the user know the file is too small to generate a fingerprint:
warn!(message = "Ignoring file smaller than fingerprint_bytes", file = ?path);
This is a very welcome feature for files that are actually too small. It helps to prevent confusion around why small files aren't being tailed. Unfortunately, it can produce a lot of noise in production environments where many empty files are present.
I'm unsure if we should ignore empty files, given that it could lead to the same confusion that we experienced previously with small files. Then again, I can see the reasoning behind ignoring empty files. I'm opening this up for discussion so we can come to a conclusion about what to do in this scenario.
Update:
New log line for too small files is:
Currently ignoring file too small to fingerprint