vaadin/framework

Deprecate MultiSelectionEvent.getNewSelection

Offen

#11.756 geöffnet am 23.10.2019

 (1 Kommentar) (1 Reaktion) (0 zugewiesene Personen)Java (715 Forks)auto 404
Help wantedStale

Repository-Metriken

Stars
 (1.806 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Description copied from https://github.com/vaadin/flow/issues/6756

The class has three methods for the same thing:

Set<T> getValue()
Set<T> getAllSelectedItems()
Set<T> getNewSelection()

The first two are inherited, but getNewSelection exists only in MultiSelectionEvent.

Another reason to deprecate it is that the naming can cause confusion. We got feedback that a user expected the method to return the newly added items (compared to the old selection), i.e. what getAddedSelection returns.

JavaDocs should suggest to use getAllSelectedItems or getValue instead.

Contributor Guide