ucsd-progsys/liquidhaskell

"Incomplete patterns" error with GHC <9.0.1

Open

#1.918 geöffnet am 1. Dez. 2021

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)Haskell (157 Forks)batch import
good first issue

Repository-Metriken

Stars
 (1.306 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 2T 18h) (12 gemergte PRs in 30 T)

Beschreibung

GHC 8.10.7 but not GHC 9.0.1 reports "Pattern match(es) are non-exhaustive" in a few places.

https://github.com/ucsd-progsys/liquidhaskell/pull/1915 added {-# OPTIONS_GHC -Wno-incomplete-patterns #-} to files where this erroneous warning was reported since they are all false positives.

This ticket should be resolved by either investigating the root cause of the erroneous warning under GHC 8.10.7 and fixing it, or by waiting until we're happy to drop support for GHC <9.0.1. Either way, this ticket should not be marked as resolved before all -Wno-incomplete-patterns are removed from the code base: the pattern exhaustiveness check is generally a Good Thing and should not stay disabled longer than absolutely necessary!

Contributor Guide