tikv/tikv

Fix Clippy warnings

Offen

#8.336 geöffnet am 26.07.2020

 (6 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Rust (2.189 Forks)batch import
difficulty/easyhelp wantedstatus/mentortype/enhancement

Repository-Metriken

Stars
 (15.922 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 28T 9h) (68 gemergte PRs in 30 T)

Beschreibung

make clippy results in one Clippy warning (not sure how this made it past CI) in components/tidb_query_codegen, which seems easy to fix.

When running make clippy we disable a lot of warnings, when running cargo clippy we get the default set of lints and we see a lot of Clippy warnings. Some of those really should be ignored, but some could be easily fixed. You can see even more things that could be fixed with -Wrust-2018-idioms (cc #4301)

It would be great to fix a bunch of those, and perhaps re-enable the lints if appropriate.

If you have any questions about whether a warning should be fixed or not, please ask me here or in Slack.

Contributor Guide