[Feature]: Presto Module uses the outdated Docker Image of `ghcr.io/trinodb/presto` and needs to be updated to `prestodb/presto` · testcontainers/testcontainers-java#8657

2024-05-21T05:24:24.000Z

### Module Presto ### Problem - Presto Module uses the outdated Docker Image of `ghcr.io/trinodb/presto` and needs to be updated to `prestodb/presto`. - Refer to https://github.com/testcontainers/testcontainers-java/blob/1.19.8/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java and https://github.com/orgs/trinodb/packages/container/package/presto . `ghcr.io/trinodb/presto` has not been updated in 3 years. - I'm confused by the instructions at https://java.testcontainers.org/modules/databases/presto/ . > This module is deprecated, use Trino module. - The problem is, development of `presto` has been active, see https://hub.docker.com/r/prestodb/presto and https://github.com/prestodb/presto . ### Solution - Use `prestodb/presto` instead of `ghcr.io/trinodb/presto` in `org.testcontainers.containers.PrestoContainer`. ### Benefit - This would obviously clarify the current situation regarding Presto. Presto is still maintained normally, so the corresponding testcontainers module should not be marked as deprecated. ### Alternatives - Maybe not. I'm not sure why `ghcr.io/trinodb/presto` was used initially. ### Would you like to help contributing this feature? No

(4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Java (1.588 Forks)batch import

help wantedtype/feature

Repository-Metriken

Stars: (7.535 Stars)
PR-Merge-Metriken: (Durchschn. Merge 2T 17h) (2 gemergte PRs in 30 T)

Beschreibung

Module

Presto

Problem

Presto Module uses the outdated Docker Image of ghcr.io/trinodb/presto and needs to be updated to prestodb/presto.
Refer to https://github.com/testcontainers/testcontainers-java/blob/1.19.8/modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java and https://github.com/orgs/trinodb/packages/container/package/presto . ghcr.io/trinodb/presto has not been updated in 3 years.
I'm confused by the instructions at https://java.testcontainers.org/modules/databases/presto/ .

This module is deprecated, use Trino module.

The problem is, development of presto has been active, see https://hub.docker.com/r/prestodb/presto and https://github.com/prestodb/presto .

Solution

Use prestodb/presto instead of ghcr.io/trinodb/presto in org.testcontainers.containers.PrestoContainer.

Benefit

This would obviously clarify the current situation regarding Presto. Presto is still maintained normally, so the corresponding testcontainers module should not be marked as deprecated.

Alternatives

Maybe not. I'm not sure why ghcr.io/trinodb/presto was used initially.

Would you like to help contributing this feature?

Contributor Guide

Research-Richtung: Finden Sie die Datei PrestoContainer.java im presto Modul und ersetzen Sie die Docker Image Zeichenfolge von `ghcr.io/trinodb/presto` durch `prestodb/presto`. Aktualisieren Sie entsprechende Tests oder Dokumentation.
Tech Stack: java
Domain: backendtesting qa
Issue Type: Funktion
Schwierigkeit: 2
Geschätzte Zeit: 1-3 Stunden
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: GitJava
Einsteigerfreundlichkeit: 80