termux/termux-packages

Regarding libomp

Offen

#6.145 geöffnet am 14.12.2020

 (10 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Shell (4.089 Forks)batch import
discussionenhancementhelp wanted

Repository-Metriken

Stars
 (16.216 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 3T 5h) (153 gemergte PRs in 30 T)

Beschreibung

https://github.com/android/ndk/blob/master/Changelogs/Changelog-r21.md

Apparently since NDK r21, it ships a shared variant of libomp. This is more or less proven to be true as per #6140.

I think we should probably ship it like we do for libc++ anyway, especially when we never shipped a libomp.so in our clang. And it seems to me that we should probably replace our libomp.a and omp.h with the ones from the NDK as well.

I'm not entirely sure if any of them could be problematic to our clang though. So I also wonder if we should just do -static-openmp in our packages and leave our clang as-is.

And I guess it's not impossible / entirely unacceptable to ship only the shared variant from the NDK as runtime library for our packages, and configure/patch our clang to always set -static-openmp. Whether it's a better approach than the above two is in doubt though.

What do you think?

Contributor Guide