tektoncd/pipeline

Disallow unknown keys in feature-flags configmap

Offen

#6.938 geöffnet am 18.07.2023

 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Go (1.943 Forks)auto 404
Hacktoberfesthelp wanted

Repository-Metriken

Stars
 (9.013 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 9T 3h) (137 gemergte PRs in 30 T)

Beschreibung

Currently, we don't perform any validation of the feature flags configmap. https://github.com/tektoncd/pipeline/pull/6935 adds validation for keys representing existing feature flags, but it's still possible to misspell a feature flag or add a flag that's no longer supported, thinking it has an effect (example: https://github.com/tektoncd/pipeline/pull/6937). We should validate that the configmap doesn't contain any unknown keys. We will probably need to fix https://github.com/tektoncd/pipeline/issues/4542 first, otherwise upgrades will cause problems if we remove feature flags.

Contributor Guide