strawberry-graphql/strawberry-django

LSP: warn on `fields="__all__"` and add code action to expose all fields

Offen

#558 geöffnet am 14.06.2024

 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (152 Forks)auto 404
enhancementhelp wanted

Repository-Metriken

Stars
 (496 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

We don't have an LSP for Strawberry Django, but in case we add one I think this feature would be neat to have.

We allow to use fields="__all__", which might lead to security issues, so the LSP could warn when using that, and also provide a code action that does what __all__ does, but with code

From this:

@strawberry.django.type(models.Flyer, fields="__all__")
class Flyer:
    ...

To this:

@strawberry.django.type(models.Flyer)
class Flyer:
    id: auto
    title: auto

We could also add code action to expose additional fields :)

Contributor Guide