storybookjs/storybook

Explore replacing express with fastify in dev server

Closed

#17.971 geöffnet am 15. Apr. 2022

Auf GitHub ansehen
 (18 Kommentare) (3 Reaktionen) (0 zugewiesene Personen)TypeScript (89.909 Stars) (10.058 Forks)batch import
feature requesthelp wanted

Beschreibung

Is your feature request related to a problem? Please describe Serving content via http2 is beneficial and greatly improves load times when serving many files. This is the case when using using a no-bundler such as the builder-vite plugin

When using builder-vite, file count can easily exceed 1k files. This causes load times to be 🐌 . We can alleviate this by enabling http2 when appropriate.

Describe the solution you'd like When running storybook with https enabled:

# optionally we can also autogenerate the selfsigned cert
# maybe take inspiration from the selfsigned package on npm
start-storybook --https --ssl-cert selfsigned.crt --ssl-key selfsigned.key

storybook assets are served via http2

Describe alternatives you've considered Accept http1.1 bottleneck

Are you able to assist to bring the feature to reality? yes, I can...

Additional context

Contributor Guide

Tech Stack
typescriptexpressnodejsvite
Domain
backendperformancedeveloper experience
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
4
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-2 days
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Node.jsExpressHTTP/2Storybook dev server architecture
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
35
Research-Richtung
Investigate the current dev server implementation in Storybook's `lib/core server` directory, which uses Express. Evaluate Fastify as a replacement, focusing on its built in HTTP/2 support and compatibility with existing middleware. Review the issue comments for any design discussions or obstacles raised. Consider automatically generating self signed certificates for HTTPS as suggested.