stenciljs/eslint-plugin

bug: own-methods-must-be-private enforces `private` accessor on `#name` while typescript disallowes it

Open

#125 geöffnet am 27. Nov. 2024

Auf GitHub ansehen
 (1 Kommentar) (1 Reaktion) (0 zugewiesene Personen)TypeScript (37 Forks)auto 404
Help Wanted

Repository-Metriken

Stars
 (71 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Prerequisites

Stencil ESLint Version

0.8.0

Current Behavior

When using fields and methods marked with private identifier # like #methodName we get warning from eslint, triggering the rule ESLint: Own class methods cannot be public(@stencil-community/ own-methods-must-be-private), the fix is to add the private modifier. This on the other hand fails with typescript TS18010: An accessibility modifier cannot be used with a private identifier.

Expected Behavior

Have eslint recognize names starting with # as being private, and don't report violation.

Steps to Reproduce

Have a simple component like:

@Component({/*...*/})
class foo{
#someName(){ /*...*/ }
}

Eslint will try to add the private keyword, but then typescript reports invalid syntax.

Code Reproduction URL

no url

Additional Information

No response

Contributor Guide