stagas/mono

Freeverb needs improvement

Open

#1 geöffnet am 1. Feb. 2023

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (0 Forks)github user discovery
enhancementgood first issue

Repository-Metriken

Stars
 (9 Stars)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Freeverb has a lot of repetition happening:

https://github.com/stagas/mono/blob/80e52042586c33b77edf523b890564c96525e9f8/src/lib/mono.ts#L118-L158

Compared to the JS version which is much more concise:

https://github.com/opendsp/freeverb/blob/08632d11dc4132e13ee0e993e3e42b4e9daeabcb/index.js#L42-L50

To improve this case and make it more concise, we possibly need additional syntax/operators.

Contributor Guide