slackapi/hubot-slack

Add support for `response.sendPrivate`

Open

#442 geöffnet am 29. Sept. 2017

Auf GitHub ansehen
 (7 Kommentare) (2 Reaktionen) (0 zugewiesene Personen)CoffeeScript (2.339 Stars) (637 Forks)batch import
enhancementgood first issue

Beschreibung

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

It'd be nice to have response.sendPrivate which basically sends a direct message to the given user that initiated that response. It would be a shortcut for this mainly:

robot.messageRoom msg.message.user.name, "Hello!"

This is supported by hubot-irc, hubot-test-helper and hubot-rocketchat. Probably it would be also easier for users to figure out sending private messages quick and easy.(Check #159 and #299)

I'd like to contribute this, but I'm not really sure how to write to test it with the stubs and whatever we have in place.

Contributor Guide

Tech Stack
javascriptnodejs
Domain
backendapi
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Basic understanding of HubotNode.js development environmentFamiliarity with Slack API messaging
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
70
Research-Richtung
Examine the existing `response.send` method and the `robot.messageRoom` implementation in the codebase. Look at issues #159 and #299 for additional context on private messaging. Review the test files (likely in test/ directory) to understand how stubs are used for testing Slack API calls. Consider creating a simple test that verifies the private message is sent to the correct user using the existing testing patterns.