slackapi/hubot-slack

Match on raw text instead of formatted text on incoming messages

Open

#241 geöffnet am 9. Okt. 2015

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)CoffeeScript (637 Forks)batch import
enhancementgood first issue

Repository-Metriken

Stars
 (2.339 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

This was originally filed at https://github.com/github/hubot/issues/1053 but I believe this to be an adapter specific problem. From @callumacrae:

We have a script which starts like this:

robot.hear /some sentence here/i, (msg) ->

However, it doesn't hear it if the words are formatted at all, e.g. "some sentence here".

Would it be possible / desired to remove formatting from messages before parsing them?

I suggested this:

Slack already has a place it strips formatting for links. That'd be a good place to do it for other things: https://github.com/slackhq/hubot-slack/blob/master/src/slack.coffee#L153-L192

I think it is going to be up to the adapters to strip formatting like this. They probably should preserve the raw message in case an adapter-specific script wants to do something about, like hubot-slack does here: https://github.com/slackhq/hubot-slack/blob/master/src/slack.coffee#L112-L120

Contributor Guide