`NonEmptyObject` fails for objects with dynamic properties · sindresorhus/type-fest#821

(3 Kommentare) (1 Reaktion) (0 zugewiesene Personen)TypeScript (12.328 Stars) (471 Forks)batch import

buggood first issuehelp wanted

Beschreibung

The following code is considered as valid by Typescript, although I was expecting it to complain that the filter foo in commonArguments was empty.

import type { NonEmptyObject } from "type-fest"

interface CommonArguments {
  [filter: string]: NonEmptyObject<{ [argument: string]: string | number | undefined }>
}

export const commonArguments: CommonArguments = {
  foo: {}
}

Contributor Guide

Tech Stack: typescript
Domain: developer experience
Issue Type: bug
Schwierigkeit: 3
Geschätzte Zeit: half day
Aktivitätsstatus: fresh
Klarheit: mostly clear
Voraussetzungen: understanding of TypeScript conditional typesfamiliarity with type fest utilities
Einsteigerfreundlichkeit: 40
Research-Richtung: The issue is that the `NonEmptyObject` type does not correctly reject objects with index signatures when the object is empty. The problem lies in the type definition likely using a conditional type that checks if all keys are optional or similar. Investigate the current implementation in the source file (likely `source/non empty object.d.ts`). Consider adjusting the logic to handle index signatures by checking if the object has any known keys or if it is assignable to `Record<string, never>`. Review the TypeScript issue tracker for similar patterns. Look at linked PRs or comments for additional context.