shentao/vue-multiselect

Allow a custom (modifier) class for multiselect

Open

#667 geöffnet am 13. März 2018

Auf GitHub ansehen
 (6 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (6.559 Stars) (994 Forks)batch import
enhancementgood first issue

Beschreibung

Hi! I love how multiselect is built using BEM, which nicely matches with our workflow.

However we have several variations of multiselect on our site, and we already have two different styles for these dropdowns. The only possibility I have now is to add styling based on inheritance (eg wrap it in a div), which is kind of anti-BEM ;)

I would prefer to be able to pass a custom prop or option that allows for an additional modifier, so that the base class "multiselect" would become "multiselect multiselect--filter" for example.

Contributor Guide

Tech Stack
vuejavascriptcss
Domain
frontend
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
fresh
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Vue.js basicsBEM methodologycomponent props
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60
Research-Richtung
Examine the main component file (likely src/Multiselect.vue) to understand how classes are currently applied using BEM. Look for existing props or computed classes. The feature requires adding a new prop, e.g., `customClass`, which is concatenated to the base 'multiselect' class. Check the render or template where the root element's class is defined. Also review the component's documentation (if any) to ensure consistency. The issue author expects the ability to pass a modifier like ' filter' to create 'multiselect multiselect filter'.