serverless-nextjs/serverless-next.js

Allow overriding of lambda@edge origin-request for custom paths

Open

#892 geöffnet am 1. Feb. 2021

Auf GitHub ansehen
 (5 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (3.998 Stars) (447 Forks)batch import
buggood first issue

Beschreibung

Is your feature request related to a problem? Please describe. I have a custom path on my NextJS app that I want to route through a custom Lambda@Edge function of my own, but this code overrides it even if I provide it in the input configuration.

Describe the solution you'd like Allow the override to happen, I don't think it makes sense to have a configuration that gets overridden always.

Describe alternatives you've considered Since I can't do this override I have to manually edit the default-lambda code using a custom script on the build.postBuildCommands.

Additional context

nextApp:
  component: '@sls-next/serverless-component@1.19.0-alpha.30'
  inputs:
    cloudfront:
      /custom-route/*:
        viewerProtocolPolicy: 'redirect-to-https'
        allowedHttpMethods:
          ['GET', 'HEAD', 'OPTIONS', 'PUT', 'POST', 'PATCH', 'DELETE']
        minTTL: 0
        maxTTL: 31536000
        defaultTTL: 0
        forward:
          cookies: 'all'
          queryString: true
        compress: true
        lambda@edge:
          origin-request: THIS_GETS_OVERRIDEN_WITH_THE_DEFAULT_LAMBDA_ARN

Contributor Guide

Tech Stack
typescriptnextjsawsnodejs
Domain
backendcloudinfrastructure
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Understanding of serverless nextjs component structureAWS CloudFront and Lambda@Edge basics
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
35
Research-Richtung
The issue points to code at packages/serverless components/nextjs component/src/component.ts line 647 where origin request is overridden. Investigate the logic that determines when to override and how to allow user provided lambda ARN. Check if there are existing tests or configuration handling in that file. Engage in comments to clarify the expected behavior.