rust-lang/rust-clippy
Auf GitHub ansehenManual Duration::{as_nanos,as_milis,as_secs_f64,as_secs_f32} implementation
Open
#6.068 geöffnet am 20. Sept. 2020
C-enhancementgood first issue
Repository-Metriken
- Stars
- (10.406 Stars)
- PR-Merge-Metriken
- (Durchschn. Merge 16T 6h) (79 gemergte PRs in 30 T)
Beschreibung
What it does
Recognize cases of manual re-implementation of the builtin as_nanos and as_secs_f64 and as_secs_f32 functions on Duration.
Categories
- Kind: complexity, sometimes also correctness
Drawbacks
MSRV issues, implementing the suggestion might increase the MSRV.
Example
let nanos = diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64;
let milis = diff.as_secs() * 1_000 + diff.subsec_milis() as u64;
let secs_f64 = (diff.as_secs() as f64 * 1_000.0 + diff.subsec_milis() as f64) / 1000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_milis() as f64 / 1_000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_nanos() as f64 / 1_000_000_000.0;
Could be written as:
let nanos = diff.as_nanos() as u64;
let milis = diff.as_millis() as u64;
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();