rust-lang/rust-clippy

Lint for .clone().into_boxed_str()

Open

#15.951 geöffnet am 25. Okt. 2025

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (1 zugewiesene Person)Rust (1.391 Forks)batch import
A-lintgood first issue

Repository-Metriken

Stars
 (10.406 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 16T 6h) (79 gemergte PRs in 30 T)

Beschreibung

What it does

Suggest turning s.clone().into_boxed_str() into Box::from(s.as_str()).

Possibly could be grouped together with other inefficient string conversions.

Advantage

Removes a call to __rust_realloc

Drawbacks

No response

Example

fn foo(s: &String) -> Box<str> {
    s.clone().into_boxed_str()
}

Could be written as:

fn foo(s: &String) -> Box<str> {
    Box::from(s.as_str())
}

Comparison with existing lints

redundant_clone generally doesn't consider the semantics of the

Additional Context

A GitHub search shows this unoptimal pattern is actually used fairly often.

Contributor Guide