rtfeldman/seamless-immutable

Fix tests that relied on Lodash 4

Open

#179 geöffnet am 11. Dez. 2016

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (5.367 Stars) (221 Forks)batch import
help wanted

Beschreibung

I mistakenly upgraded our tests to use Lodash 4, not realizing some of the features in Lodash 4 did not work in IE9-10. (seamless-immutable itself does not depend on Lodash; this was for tests only.)

We subsequently added tests that relied on those features, causing IE9-10 tests to fail. I have reverted to Lodash 3.10 and disabled those tests, so that the other tests can complete cross-browser testing as normal. However, now we have a few pending tests that need to be rewritten to use Lodash 3.10 features instead of the Lodash 4 features they currently use.

The pending tests are marked with xit in the test suite.

Help on this would be greatly appreciated! ❤️

Contributor Guide

Tech Stack
javascript
Domain
testing
Issue Type
test
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
JavaScript fundamentalsLodash experience
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
65
Research-Richtung
Locate the tests marked with `xit` in the test suite. Identify which Lodash 4 features were used and replace them with equivalent Lodash 3.10 functions. The test files are likely in the repository's test directory. Refer to Lodash 3.10 documentation for compatibility.