replicatedhq/ship

shipapps: HelmValues step should have customizable output path

Offen

#857 geöffnet am 11.03.2019

 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Go (68 Forks)auto 404
good first issuehelp wanted

Repository-Metriken

Stars
 (635 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Right now the YAML schema for HelmValues allows setting the source path for the values.yaml file, but it always writes the saved values to .ship/tmp/values.yaml (and in state.json). It would be great if there was a field on the HelmValues step that allowed a configurable output path.

this could be used like

---
assets:
  v1: []

config:
  v1: []

lifecycle:
  v1:
    - render:
        root: ./
        assets:
          v1:
            - github:
                dest: ./installer/consul
                repo: helm/charts
                path: stable/consul
                ref: master
                strip_path: true
    - helmValues:
        path: installer/consul/values.yaml
        dest: installer/consul/custom-values.yaml # dest is not a field today
    - render:
        root: ./
        assets:
          v1:
            - helm:
                dest: ./installer/base
                local:
                  chart_root: ./installer/consul
                values_from:
                  path: installer/consul/custom-values.yaml # use the dest from above
    - kustomize:
        base: installer/base
        dest: installer/rendered.yaml

Contributor Guide