qmk/qmk_firmware

[Bug] Docker builds broken when both Podman and Docker are installed

Open

#19.648 geöffnet am 20. Jan. 2023

Auf GitHub ansehen
 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C (43.867 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (20.368 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 20T 9h) (27 gemergte PRs in 30 T)

Beschreibung

Describe the Bug

#19561 recently got merged into master.

However, after pulling it, I now get the following output instead of a properly working build: image This requires additional keyboard interaction, and only selecting the docker.io image works - the other images result in either manifest unknown or repo not found.

To my surprise, it turned out that QMK suddenly started using Podman instead of Docker!

I am running Fedora 35. I believe Podman was automatically installed, but I manually installed Docker because - as #19561 mentions - Podman does not have feature-parity with Docker. This is probably not an unusual scenario.

#19561 reordered the scripts to give priority to Podman because Podman does not support the Docker API 100%. The actual issue seemed to be that the scripts did not properly detect an aliased Podman, which meant to it accidentally using Docker-intended flags with Podman. Checking for Podman first meant it was now using the proper flags, but it also means that it switched the Docker backend for the people who genuinely have both installed. This seems like a mistake to me - and if not it is a rather large change to suddenly dump into master.

Basically, it seems it fixed the case where docker is aliased to Podman, but broke the case where both Docker and Podman are installed. It probably needs to be reverted and redone with proper alias detection.

@-ing @zvecr because he processed the original PR.

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor Guide