qmk/qmk_firmware

[Bug] NOOP keys kill combos

Open

#19.446 geöffnet am 30. Dez. 2022

Auf GitHub ansehen
 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C (43.867 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (20.368 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 20T 9h) (27 gemergte PRs in 30 T)

Beschreibung

Describe the Bug

The issue is that whenever a NOOP key is pressed down along with a valid combo, the combo doesn't fire.

Use case:

I am using an ortholinear split keyboard with left shift + right shift combo as caps lock toggle. The right shift is 2U with a POS keycap so the underlaying switches are KC_RSFT and XXXXXXX (using the right switch as a stabilizer because the pcb doesn't support 2U key in that position).

Expected behavior:

NOOP shouldn't interfere with combos because by definition the key should be ignored.

Notes:

I tried the combo with 1U keycaps (meaning the NOOP key is not pressed) and it works fine, so the problem is indeed the NOOP interfering with combos.

Keyboard Used

keebio/viterbi/rev2

Link to product page (if applicable)

https://keeb.io/products/viterbi-keyboard-pcbs-5x7-70-split-ortholinear

Operating System

Microsoft Windows 11

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

Contributor Guide