qmk/qmk_firmware

[Bug] Retro Shift not working on Mod Tap keys

Open

#15.458 geöffnet am 12. Dez. 2021

Auf GitHub ansehen
 (8 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C (43.867 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (20.368 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 20T 9h) (27 gemergte PRs in 30 T)

Beschreibung

Describe the Bug

Using Retro_Shift has no effect on my Mod Tap keys. Auto Shift is enabled and works for normal alpha keys. But when exceeding the AUTO_SHIFT_TIMEOUT on the Mod Tap keys without pressing an additional key, retro shift doesn't trigger.

System Information

  • Keyboard: Planck
    • Revision (if applicable): rev6_drop
  • Operating system: macOS 12.1
  • AVR GCC version: 8.4.0
  • ARM GCC version: 8.3.1
  • QMK Firmware version: 0.15.6
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

Retro Shift added in https://github.com/qmk/qmk_firmware/commit/d9393b86842b7ef143259b5f771ae7969f98cbb4

Relevant part of config.h:

// Tapping Term
#define TAPPING_TERM 300
#define TAPPING_TERM_PER_KEY

// Prevent normal rollover on alphas from accidentally triggering mods.
#define IGNORE_MOD_TAP_INTERRUPT

// Auto Shift
#define NO_AUTO_SHIFT_NUMERIC
#define NO_AUTO_SHIFT_SPECIAL
#define AUTO_SHIFT_REPEAT
#define AUTO_SHIFT_TIMEOUT TAPPING_TERM
#define AUTO_SHIFT_NO_SETUP
#define RETRO_SHIFT

Contributor Guide